Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SidedStorageBlockEntity's side as nullable #3281

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

deirn
Copy link
Member

@deirn deirn commented Aug 27, 2023

ItemStorage.SIDED and FluidStorage.SIDED have had their direction context changed to be nullable, but the SidedStorageBlockEntity methods are not marked as so.

@Technici4n Technici4n requested a review from a team August 27, 2023 08:25
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Aug 29, 2023
@modmuss50 modmuss50 merged commit 195226a into FabricMC:1.20.1 Sep 3, 2023
5 checks passed
modmuss50 pushed a commit that referenced this pull request Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request merge me please Pull requests that are ready to merge small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants